[PATCH 1/2] xfsprogs: remove unused argument in trans_iput

Mark Tinguely tinguely at sgi.com
Wed Apr 30 09:50:15 CDT 2014


On 04/30/14 09:47, Eric Sandeen wrote:
> On 4/30/14, 8:48 AM, Mark Tinguely wrote:
>> >  Remove the unused second argument to xfs_iput() and
>> >  xfs_trans_iput().
>> >
>> >  Introduce the define "IRELE()" and use in place of xfs_iput().
> Why do this?  We had been moving away from the upper-case-macro-
> redefined-to-a-function meme... what does this #define gain?
>
> libxfs_iget/libxfs_iput pairs seem more obvious than
> libxfs_iget/IRELE()...
>
> Thanks,
> -Eric
>

To be consistent with the kernel code.

--Mark.



More information about the xfs mailing list