[PATCH] xfs: test for shut down fs in xfs_dir_fsync()

Eric Sandeen sandeen at redhat.com
Mon Apr 28 12:18:31 CDT 2014


On 4/28/14, 11:47 AM, Christoph Hellwig wrote:
> On Mon, Apr 28, 2014 at 11:35:16AM -0500, Eric Sandeen wrote:
>> Similar to xfs_file_fsync(), I think xfs_dir_fsync() needs
>> to test for a shut down fs,
> 
> It probably should.
> 
>> lest we go down paths we'll
>> never be able to complete; Boris reported that during some
>> stress tests he had threads stuck in xlog_cil_force_lsn
>> via xfs_dir_fsync().
> 
> But this could still happen if we get a shutdown coming in after that
> test.

True... that looked a bit hairier to sort out.  :(

-Eric



More information about the xfs mailing list