[PATCH] xfs: bulletfproof xfs_qm_scall_trunc_qfiles()

Jeff Liu jeff.liu at oracle.com
Tue Apr 22 07:42:51 CDT 2014


On 04/22 2014 14:27 PM, Christoph Hellwig wrote:
> On Mon, Apr 21, 2014 at 03:45:08PM -0500, Eric Sandeen wrote:
>> Coverity noticed that if we sent junk into
>> xfs_qm_scall_trunc_qfiles(), we could get back an
>> uninitialized error value.  So sanitize the flags we
>> will accept, and initialize error anyway for good measure.
>>
>> (This bug may have been introduced via c61a9e39).

Indeed, my mistake.

>>
>> Should resolve Coverity CID 1163872.
>>
>> Signed-off-by: Eric Sandeen <sandeen at redhat.com>
> 
> Looks good,
> 
> Reviewed-by: Christoph Hellwig <hch at lst.de>

Looks good to me too.

Reviewed-by: Jie Liu <jeff.liu at oracle.com>


Thanks,
-Jeff



More information about the xfs mailing list