[PATCH 10/19] NET: set PF_FSTRANS while holding sk_lock

NeilBrown neilb at suse.de
Wed Apr 16 21:38:37 CDT 2014


On Wed, 16 Apr 2014 09:00:02 -0400 (EDT) David Miller <davem at davemloft.net>
wrote:

> From: Eric Dumazet <eric.dumazet at gmail.com>
> Date: Tue, 15 Apr 2014 22:13:46 -0700
> 
> > For applications handling millions of sockets, this makes a difference.
> 
> Indeed, this really is not acceptable.

As you say...
I've just discovered that I can get rid of the lockdep message (and hence
presumably the deadlock risk) with a well placed:

		newsock->sk->sk_allocation = GFP_NOFS;

which surprised me as it seemed to be an explicit GFP_KERNEL allocation that
was mentioned in the lockdep trace.  Obviously these traces require quite
some sophistication to understand.

So - thanks for the feedback, patch can be ignored.

Thanks,
NeilBrown
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 828 bytes
Desc: not available
URL: <http://oss.sgi.com/pipermail/xfs/attachments/20140417/0c733ecc/attachment.sig>


More information about the xfs mailing list