[PATCH] xfstests: log running test to dmesg

Dave Chinner david at fromorbit.com
Wed Apr 16 18:40:27 CDT 2014


On Wed, Apr 16, 2014 at 04:37:33PM -0500, Eric Sandeen wrote:
> We already log the running test to system logs via "logger"
> but viro pointed out that we can use /dev/kmsg to insert it
> into dmesg as well.  When looking at the serial console that
> could be pretty useful.
> 
> Thanks to viro for the test -w suggestion too.
> 
> Signed-off-by: Eric Sandeen <sandeen at redhat.com>
> ---
> 
> diff --git a/check b/check
> index 268417c..09b2320 100755
> --- a/check
> +++ b/check
> @@ -457,6 +457,7 @@ do
>  	$timestamp && echo -n "	["`date "+%T"`"]"
>  	[ ! -x $seq ] && chmod u+x $seq # ensure we can run it
>  	$LOGGER_PROG "run xfstest $seqnum"
> +	test -w /dev/kmsg && echo "run xfstest $seqnum" > /dev/kmsg
>  	./$seq >$tmp.rawout 2>&1
>  	sts=$?
>  	$timestamp && _timestamp

Might it be worthwhile adding a "_log" function that can take an
arbitrary string so in future it is easy to add new log messages?

Cheers,

Dave.
-- 
Dave Chinner
david at fromorbit.com



More information about the xfs mailing list