[xfstests PATCH] renameat2 syscall: turn EEXIST into ENOTEMPTY

Dave Chinner david at fromorbit.com
Tue Apr 15 19:31:05 CDT 2014


On Mon, Apr 14, 2014 at 12:49:53PM +0200, Miklos Szeredi wrote:
> From: Miklos Szeredi <mszeredi at suse.cz>
> 
> XFS is returning EEXIST rather than ENOTEMPTY for several of
> these rename tests. The rename man page says this about the errors:
> 
>        ENOTEMPTY or EEXIST
>               newpath is a nonempty directory, that is, contains
>               entries other than "." and "..".
> 
> Which implies that both errors are valid and so the test should pass
> in either case.
> 
> Signed-off-by: Miklos Szeredi <mszeredi at suse.cz>

looks good.

Reviewed-by: Dave Chinner <dchinner at redhat.com>
-- 
Dave Chinner
david at fromorbit.com



More information about the xfs mailing list