[PATCH v3 4/4] xfs: fold xfs_create_tmpfile() into xfs_create()

Christoph Hellwig hch at infradead.org
Tue Apr 15 12:51:30 CDT 2014


On Tue, Apr 15, 2014 at 12:18:26PM -0400, Brian Foster wrote:
> xfs_create_tmpfile() duplicates most of xfs_create() with the exception
> of a couple minor differences. We use a unique transaction reservation
> and place the allocated inode on the unlinked list rather than create a
> directory entry for it.
> 
> Fold xfs_create_tmpfile() into xfs_create() to reduce some of this
> duplication. The name parameter that represents the name of the
> directory entry to create is now conditional and its existence dictates
> whether a directory entry is created for the inode or not.
> 
> Signed-off-by: Brian Foster <bfoster at redhat.com>

Looks correct although I still can't get excited about it..

Reviewed-by: Christoph Hellwig <hch at lst.de>



More information about the xfs mailing list