[PATCH 2/4] fs: Prevent doing FALLOC_FL_ZERO_RANGE on append only file
Christoph Hellwig
hch at infradead.org
Sat Apr 12 10:19:35 CDT 2014
On Fri, Apr 11, 2014 at 08:57:43PM +0200, Lukas Czerner wrote:
> /*
> - * It's not possible to punch hole or perform collapse range
> - * on append only file
> + * It's not possible to punch hole, perform collapse range
> + * or zero range on append only file
> */
> - if (mode & (FALLOC_FL_PUNCH_HOLE | FALLOC_FL_COLLAPSE_RANGE)
> + if (mode & (FALLOC_FL_PUNCH_HOLE | FALLOC_FL_COLLAPSE_RANGE |
> + FALLOC_FL_ZERO_RANGE)
Might be better to make this a negative test fo the operation that is
allowed on an appen only file. That's also much better future proof.
More information about the xfs
mailing list