[PATCH 3/6] xfs: xfs_vm_write_end truncates too much on failure

Christoph Hellwig hch at infradead.org
Thu Apr 10 05:35:55 CDT 2014


On Thu, Apr 10, 2014 at 03:00:50PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner at redhat.com>
> 
> Similar to the write_begin problem, xfs-vm_write_end will truncate
> back to the old EOF, potentially removing page cache from over the
> top of delalloc blocks with valid data in them. Fix this by
> truncating back to just the start of the failed write.
> 
> Signed-off-by: Dave Chinner <dchinner at redhat.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch at lst.de>

Any reason you used max_t in the previous one, and opencode it here?



More information about the xfs mailing list