[PATCH] libxfs: remove never-read "offset" assignment in readbufr_map & writebufr

Mark Tinguely tinguely at sgi.com
Wed Apr 9 15:59:25 CDT 2014


On 04/09/14 14:20, Eric Sandeen wrote:
> libxfs_readbufr_map()&  libxfs_writebufr() iterate
> over bp->b_map[] and read each chunk.  The loops start
> out correctly, getting the offset from bm_bn and the
> length from bm_len.  After the IO it correctly
> advances the target buffer pointer by len, but then
> inexplicably advances "offset" by len as well.  The
> whole point of this exercise is to handle discontiguous
> ranges - marching offset along by length of IO done
> is incorrect.
>
> Thankfully offset is immediately reset to the proper
> value again at the top of the loop for the next range,
> so this is harmless, other than being confusing.
>
> Signed-off-by: Eric Sandeen<sandeen at redhat.com>

Looks good.

Reviewed-by: Mark Tinguely <tinguely at sgi.com>



More information about the xfs mailing list