[PATCH v2 0/2] xfs: tmpfile fixes for inode security/acl

Brian Foster bfoster at redhat.com
Wed Apr 9 14:21:49 CDT 2014


Hi all,

Here's a v2 of the tmpfile and selinux deadlock patch. Since we also
probably want to create the default acl, I created a generic helper out
of xfs_vn_mknod().

Once I got that far, I noticed xfs_create_tmpfile() looked quite similar
to xfs_create(). Patch 2 folds the former into the latter and eliminates
the duplicate code. Patch 2 is optional with regard to addressing the
selinux issue. Lightly tested... thoughts, reviews, flames appreciated.

Brian

v2:
- Added a generic create helper to inherit the security/acl init. code
  in the tmpfile path.
- Added patch 2 to fold xfs_create_tmpfile() into xfs_create().

Brian Foster (2):
  xfs: fix tmpfile/selinux deadlock and initialize security/acl
  xfs: fold xfs_create_tmpfile() into xfs_create()

 fs/xfs/xfs_inode.c | 184 ++++++++++++++---------------------------------------
 fs/xfs/xfs_inode.h |   2 +-
 fs/xfs/xfs_iops.c  |  43 +++++++++----
 fs/xfs/xfs_trace.h |   7 +-
 4 files changed, 81 insertions(+), 155 deletions(-)

-- 
1.8.3.1



More information about the xfs mailing list