[PATCH] xfsprogs: remove write-only assignments

Mark Tinguely tinguely at sgi.com
Wed Apr 9 12:50:12 CDT 2014


On 04/09/14 12:13, Eric Sandeen wrote:
> There are many instances where variable assignments are made,
> but never read (or are re-assigned before they are read).
> The Clang static analyzer finds these.
>
> Here's a chunk of what I think are trivial removals of such
> assignments; other detections point to more serious problems
> (or are shared w/ kernel code so should probably be fixed there
> first).
>
> Signed-off-by: Eric Sandeen<sandeen at redhat.com>
> ---
>
> These may be a bit tedious to review; perhaps graphical diff
> w/ more context would help in some cases?
>

This patch length is not so bad. Light reading with lunch. They all look 
good to me.

Reviewed-by: Mark Tinguely <tinguely at sgi.com>



More information about the xfs mailing list