[PATCH] xfs: change the immutable in xfs_open_by_handle

[Dave Chinner]

On Tue, Sep 10, 2013 at 01:47:20PM -0500, Mark Tinguely wrote:
> This patch allows clients like DMF to modify an immutable file
> without changing the immutable capability on the file, which
> would expose the file to change.
> 
> This patch is restricted to holders of the CAP_LINUX_IMMUTABLE,
> so no addition security risk has been introduced.
> 
> Signed-off-by: Greg Banks <gbanks at sgi.com>
> Singed-off-by: Mark Tinguely <tinguely at sgi.com>
> ---
>  fs/xfs/xfs_ioctl.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> Index: b/fs/xfs/xfs_ioctl.c
> ===================================================================
> --- a/fs/xfs/xfs_ioctl.c
> +++ b/fs/xfs/xfs_ioctl.c
> @@ -237,7 +237,9 @@ xfs_open_by_handle(
>  		goto out_dput;
>  	}
>  
> -	if ((fmode & FMODE_WRITE) && IS_IMMUTABLE(inode)) {
> +	if ((permflag & FMODE_WRITE) &&

Why the conversion from fmode to permflag? At minimum, this will
probably throw sparse warnings for comparing a FMODE_* flag against
a variable that is not a fmode_t....

Cheers,

Dave.
-- 
Dave Chinner
david at fromorbit.com