[PATCH, RFC] xfs: don't break from growfs ag update loop on error
Dave Chinner
david at fromorbit.com
Mon Sep 9 17:08:24 CDT 2013
On Mon, Sep 09, 2013 at 03:36:18PM -0500, Eric Sandeen wrote:
> On 8/15/13 1:15 PM, Eric Sandeen wrote:
> > When xfs_growfs_data_private() is updating backup superblocks,
> > it bails out on the first error encountered, whether reading or
> > writing:
>
> Any thoughts on this one? W/ the verifiers, we have a higher
> chance of encountering an error, and leaving the rest of the
> supers un-updated. Repair will then possibly revert the fs to
> it's pre-growfs state, and data loss will ensue...
Sorry, I must have missed this. I remember discussing it with you.
The change looks fine to me, but I haven't tested it at all.
Acked-by: Dave Chinner <david at fromorbit.com>
Cheers,
Dave.
--
Dave Chinner
david at fromorbit.com
More information about the xfs
mailing list