[PATCH 52/55] xfs: btree block LSN escaping to disk uninitialised

[Mark Tinguely]

On 09/04/13 17:05, Dave Chinner wrote:
> From: Dave Chinner<dchinner at redhat.com>
>
> When testing LSN ordering code for v5 superblocks, it was discovered
> that the the LSN embedded in the generic btree blocks was
> occasionally uninitialised. These values didn't get written to disk
> by metadata writeback - they got written by previous transactions in
> log recovery.
>
> The issue is here that the when the block is first allocated and
> initialised, the LSN field was not initialised - it gets overwritten
> before IO is issued on the buffer - but the value that is logged by
> transactions that modify the header before it is written to disk
> (and initialised) contain garbage. Hence the first recovery of the
> buffer will stamp garbage into the LSN field, and that can cause
> subsequent transactions to not replay correctly.
>
> The fix is simply to initialise the bb_lsn field to zero when we
> initialise the block for the first time.
>
> Signed-off-by: Dave Chinner<dchinner at redhat.com>
> ---

Looks good, same as kernel commit b58fa554.

Reviewed-by: Mark Tinguely <tinguely at sgi.com>