[PATCH 2/3] xfstests: Obey mkfs options for sized filesystems on XFS

Christoph Hellwig hch at infradead.org
Tue Sep 3 02:34:50 CDT 2013


On Tue, Sep 03, 2013 at 10:14:54AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner at redhat.com>
> 
> The XFS implementation of _scratch_mkfs_sized ignores MKFS_OPTIONS
> when a custom block size is set and so isn't testing things like
> CRCs on such sized filesytsems. Fix this by ensuring we don't try to
> override the block size is it is set in MKFS_OPTIONS. xfs/204 shows
> this problem.
> 
> Signed-off-by: Dave Chinner <dchinner at redhat.com>

Looks good.

Maybe someone more familar with the other mkfs tools should cross-check
those as well.

Reviewed-by: Christoph Hellwig <hch at lst.de>



More information about the xfs mailing list