[PATCH 2/2] xfs: fix some minor sparse warnings

Dave Chinner david at fromorbit.com
Mon Sep 2 05:09:57 CDT 2013


On Mon, Sep 02, 2013 at 01:19:54AM -0700, Christoph Hellwig wrote:
> > --- a/fs/xfs/xfs_dquot_item.c
> > +++ b/fs/xfs/xfs_dquot_item.c
> > @@ -143,6 +143,8 @@ STATIC uint
> >  xfs_qm_dquot_logitem_push(
> >  	struct xfs_log_item	*lip,
> >  	struct list_head	*buffer_list)
> > +	__releases(&lip->li_ailp->xa_lock)
> > +	__acquires(&lip->li_ailp->xa_lock)
> >  {
> 
> Having these markers indented the same amount as the parameters isn't
> very readable.  Maybe give them another tab level?

Sure. Can do.

-- 
Dave Chinner
david at fromorbit.com



More information about the xfs mailing list