[PATCH 2/2] xfs: fix some minor sparse warnings

Christoph Hellwig hch at infradead.org
Mon Sep 2 03:19:54 CDT 2013


> --- a/fs/xfs/xfs_dquot_item.c
> +++ b/fs/xfs/xfs_dquot_item.c
> @@ -143,6 +143,8 @@ STATIC uint
>  xfs_qm_dquot_logitem_push(
>  	struct xfs_log_item	*lip,
>  	struct list_head	*buffer_list)
> +	__releases(&lip->li_ailp->xa_lock)
> +	__acquires(&lip->li_ailp->xa_lock)
>  {

Having these markers indented the same amount as the parameters isn't
very readable.  Maybe give them another tab level?

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch at lst.de>



More information about the xfs mailing list