[PATCH v2] xfs:xfs_dir2_node.c: pointer use before check for null

Ben Myers bpm at sgi.com
Thu Oct 31 10:56:03 CDT 2013


On Fri, Oct 25, 2013 at 10:06:09AM -0500, Ben Myers wrote:
> On Fri, Oct 25, 2013 at 03:53:25PM +0400, Denis Efremov wrote:
> > ASSERT on args takes place after args dereference.
> > This assertion is redundant since we are going to panic anyway.
> > 
> > Found by Linux Driver Verification project (linuxtesting.org) -
> > PVS-Studio analyzer.
> > 
> > Signed-off-by: Denis Efremov <yefremov.denis at gmail.com>
> 
> Looks good. 
> 
> Reviewed-by: Ben Myers <bpm at sgi.com>

Applied.  Thanks Denis.



More information about the xfs mailing list