[PATCH] xfs: fix possible NULL dereference

Ben Myers bpm at sgi.com
Thu Oct 31 10:55:03 CDT 2013


Hey Geyslan,

On Wed, Oct 30, 2013 at 03:08:12PM -0500, Eric Sandeen wrote:
> On 10/23/13 3:34 PM, Ben Myers wrote:
> 
> > xfs: fix possible NULL dereference in xlog_verify_iclog
> > 
> > In xlog_verify_iclog a debug check of the incore log buffers prints an
> > error if icptr is null and then goes on to dereference the pointer
> > regardless.  Convert this to an assert so that the intention is clear.
> > This was reported by Coverty.
> > 
> > Reported-by: Geyslan G. Bem <geyslan at gmail.com>
> > Signed-off-by: Ben Myers <bpm at sgi.com>
> 
> Reviewed-by: Eric Sandeen <sandeen at redhat.com>

Applied this.  Many thanks!  ;)

-Ben



More information about the xfs mailing list