[PATCH 13/15] xfs: validity check the directory block leaf entry count

Ben Myers bpm at sgi.com
Tue Oct 29 15:43:19 CDT 2013


On Tue, Oct 29, 2013 at 10:11:56PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner at redhat.com>
> 
> The directory block format verifier fails to check that the leaf
> entry count is in a valid range, and so if it is corrupted then it
> can lead to derefencing a pointer outside the block buffer. While we
> can't exactly validate the count without first walking the directory
> block, we can ensure the count lands in the valid area within the
> directory block and hence avoid out-of-block references.
> 
> Signed-off-by: Dave Chinner <dchinner at redhat.com>

Looks fine.

Reviewed-by: Ben Myers <bpm at sgi.com>



More information about the xfs mailing list