[PATCH 2/2] xfstests: generic/273: do not use /proc/cpuinfo

Carlos Maiolino cmaiolino at redhat.com
Wed Oct 23 08:09:30 CDT 2013


Looks good indeed.

Reviewed-by: Carlos Maiolino <cmaiolino at redhat.com>
On Wed, Oct 23, 2013 at 03:58:44PM +0400, Stanislav Kholmanskikh wrote:
> The content of /proc/cpuinfo file is platform-dependent.
> So we can not use it reliably to check a number of available cpus.
> It would be better to use sysfs interface, as _no_of_online_cpus() does.
> 
> Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmanskikh at oracle.com>
> ---
>  tests/generic/273 |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/tests/generic/273 b/tests/generic/273
> index d149808..c028438 100755
> --- a/tests/generic/273
> +++ b/tests/generic/273
> @@ -47,7 +47,7 @@ count=2
>  
>  _threads_set()
>  {
> -	_cpu_num=`cat /proc/cpuinfo | grep "processor" | wc -l`
> +	_cpu_num=`_no_of_online_cpus`
>  	threads=$(($_cpu_num * 50))
>  	if [ $threads -gt 200 ]
>  	then
> -- 
> 1.7.1
> 
> _______________________________________________
> xfs mailing list
> xfs at oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

-- 
Carlos



More information about the xfs mailing list