[PATCH 0/5] refactor the preallocation and hole punching code

Christoph Hellwig hch at infradead.org
Sat Oct 12 02:55:03 CDT 2013


This series massages the preallocation and hole punching code into something
sane.  The big catchall xfs_change_file_space function is gone, fallocate
and the ioctl entry point now directly call the low-level functions, and
fallocate can avoid packing its arguments into the xfs_flock form and
duplicating error checking already done in the VFS.  In addition we also
use a common locking patter now, that is preallocations using the ioctl
path now also take iolock, just like fallocate and all other ioctl cases
already did beforehand.


Changes since version 1:
 - remove the unused setprealloc variable in xfs_file_fallocate
 - rebased



More information about the xfs mailing list