[PATCH 04/32] xfs: check magic numbers in dir3 leaf verifier first

[Eric Sandeen]

On 10/9/13 3:45 PM, Dave Chinner wrote:
> On Tue, Oct 08, 2013 at 06:03:43PM -0500, Eric Sandeen wrote:
>> On 9/29/13 10:15 PM, Dave Chinner wrote:
>>> From: Dave Chinner <dchinner at redhat.com>
>>>
>>> Calling xfs_dir3_leaf_hdr_from_disk() in a verifier before
>>> validating the magic numbers in the buffer results in ASSERT
>>> failures due to mismatching magic numbers when a corruption occurs.
>>> Seeing as the verifier is supposed to catch the corruption and pass
>>> it back to the caller, having the verifier assert fail on error
>>> defeats the purpose of detecting the errors in the first place.
>>>
>>> Check the magic numbers direct from the buffer before decoding the
>>> header.
>>
>> Looks good; have you sent this for the kernel yet?
>>
>> (I thought we wanted changes to hit kernelspace first) :)
> 
> Yes, commit 0f295a214bb7658ca37bd61a8a1f0cd4a9d86c1f.

Sorry I missed that, man, I swear I looked.

-Eric

> Cheers,
> 
> Dave.
>