bio_add_page rw mode check by merge_bvec_fn

NeilBrown neilb at suse.de
Fri Nov 22 23:12:34 CST 2013


On Fri, 22 Nov 2013 07:36:18 -0800 Christoph Hellwig <hch at infradead.org>
wrote:

> While this is trivial to fix it's also fairly unexpected and easy
> to get wrong for new callers.  Neil, can you explain why you
> desperately need it?

Desperately?  Not at all?
Need?  Not really.  This is just in RAID5 and merge_bvec_fn is purely an
optimisation for RAID5.
Limiting read BIOs to one chunk allows us to bypass the stripe-cache, so can
be good.
Limiting write BIOs is completely unnecessary so we currently don't bother.

So I have no objection to bvm->bi_rw being removed.

Thanks,
NeilBrown
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 828 bytes
Desc: not available
URL: <http://oss.sgi.com/pipermail/xfs/attachments/20131123/d8f716a9/attachment.sig>


More information about the xfs mailing list