[PATCH 31/36] db: enable metadump on CRC filesystems

Christoph Hellwig hch at infradead.org
Wed Nov 13 10:09:37 CST 2013


On Wed, Nov 13, 2013 at 05:40:55PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner at redhat.com>
> 
> Now that we can calculate CRCs through xfs_db, we can add support
> for recalculating CRCs on obfuscated metadump images. This simply
> requires us to call the write verifier manually before writing the
> buffer to the metadump image.
> 
> We don't need to do anything special to mdrestore, as the metadata
> blocks it reads from the image file will already have all the
> correct CRCs in them. Hence it can be mostly oblivious to the fact
> that the filesystem it is restoring contains CRCs.

All the changes in here look reasonable, but don't we need a way to
recalculate dquot crcs in metadump as well?  We seem to need a special
case for them elsewhere at least.

Do we have a testcase that exercises metadump on a filesystems with
quotas enabled and check that they still work after restore?



More information about the xfs mailing list