[PATCH] xfs_repair: suggest reboot after dangerous repair

Eric Sandeen sandeen at redhat.com
Tue Nov 12 11:14:46 CST 2013


If a "dangerous" repair (repair of a readonly mounted fs)
has been done, suggest an immediate reboot upon completion.

Signed-off-by: Eric Sandeen <sandeen at redhat.com>
---

TBH, I don't know how "dangerous" dangerous is.  Is this
still required?

diff --git a/repair/xfs_repair.c b/repair/xfs_repair.c
index 820e7a2..9e1a774 100644
--- a/repair/xfs_repair.c
+++ b/repair/xfs_repair.c
@@ -884,6 +884,11 @@ _("Note - stripe unit (%d) and width (%d) fields have been reset.\n"
 	if (verbose)
 		summary_report();
 	do_log(_("done\n"));
+
+	if (dangerously && !no_modify)
+		do_warn(
+_("Repair of readonly mount complete.  Immediate reboot encouraged.\n"));
+
 	pftrace_done();
 
 	return (0);



More information about the xfs mailing list