[PATCH] xfstests: fix src/seek_sanity_test -t option
Rich Johnston
rjohnston at sgi.com
Tue May 28 10:57:22 CDT 2013
On 05/24/2013 12:03 AM, Eric Sandeen wrote:
> _require_seek_data_hole() does not work because
> the -t (test) option of seek_sanity_test is broken,
> because of an early check for (argc != 2):
>
> # src/seek_sanity_test -t foo
> Usage: src/seek_sanity_test base_file_path
>
> So _require_seek_data_hole() doesn't see the
> "Kernel does not support" string it's looking for,
> and passes the check.
>
> So rather than _notrun-ing the test, it proceeds to
> fail with noisy errors.
>
> Fix that, make a common usage() function, and check for
> too many args as well.
>
> Signed-off-by: Eric Sandeen <sandeen at redhat.com>
Thanks, this has been committed:
commit bd13bf9e2a87a40d3aab2644967029b854ed2d11
Author: Eric Sandeen <sandeen at redhat.com>
Date: Tue May 28 10:37:39 2013 -0500
xfstests: fix src/seek_sanity_test -t option
--Rich
More information about the xfs
mailing list