xfsprogs: is it one issue?

[Zhi Yong Wu]

ah, another way by not building-in loggen, thanks.


On Mon, May 27, 2013 at 7:11 AM, Dave Chinner <david at fromorbit.com> wrote:

> On Sun, May 26, 2013 at 07:11:03AM +0800, Zhi Yong Wu wrote:
> > I remove the lines related to h_chksum, then it can work well, so i
> > guess that i should send out one patch to fix it.
>
> While it will make the code in loggen work the same (it just writes
> 0 to the field but the buffer is already zeroed) as it does now,
> it doesn't necessarily mean it works correctly. The current kernels
> validate the CRC and throw warnings if the CRC isn't correct, and
> CRC enabled kernels will simply refuse to mount.
>
> As it is, my test systems don't build loggen because
> HAVE_XLOG_ASSIGN_LSN isn't set by configure. It only gets set if
> there's an xfs/libxfs.h header file found in an include path. My
> guess is that you've run 'make install-qa' in the xfsprogs package
> at some time in the past, and that's why loggen is trying to be
> built.
>
> So Michael's quick hack to remove it just to make it compile at this
> point is probably appropriate...
>
> Cheers,
>
> Dave.
> --
> Dave Chinner
> david at fromorbit.com
>



-- 
Regards,

Zhi Yong Wu
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://oss.sgi.com/pipermail/xfs/attachments/20130527/5085c381/attachment.html>