generic/258 questions (mount issue)...

[Michael L. Semon]

Hi!  When using xfstests generic/258 with along with $TEST_RTDEV 
$TEST_LOGDEV, it tends to scream bloody murder about corrupted 
partitions and such.  In fact, the commands in the test seem to do the 
right thing when executed by hand.  So once again, I grasped for straws 
and came up with this:

--- xfstests/tests/generic/258.orig	2013-05-21 20:19:38.430754829 -0400
+++ xfstests/tests/generic/258	2013-05-21 20:10:11.509021368 -0400
@@ -62,7 +62,7 @@
  # unmount, remount, and check the timestamp
  echo "Remounting to flush cache"
  umount $TEST_DEV
-mount $TEST_DEV $TEST_DIR
+_test_mount

  # Should yield -315593940 (prior to epoch)
  echo "Testing for negative seconds since epoch"

My questions are these:

1) Was there a better way to do this?

2) Not knowing the policy on umounting $TEST_DEV, could this have been a 
test for $SCRATCH_DEV?

This was tested only on XFS with rtdev and logdev partitions enabled.

Thanks!

Michael