[PATCH 2/2] xfstests: quota not supported on realtime filesystems

[Eric Sandeen]

On 5/8/13 1:04 AM, Dave Chinner wrote:
> From: Dave Chinner <dchinner at redhat.com>
> 
> Realtime XFS filesystems do not support quotas, so quota tests
> always fail on such filesystems. Add a check to _require_quota to
> detect this situation and notrun the quota tests...
> 
> Signed-off-by: Dave Chinner <dchinner at redhat.com>

Reviewed-by: Eric Sandeen <sandeen at redhat.com>

(PS why is USE_EXTERNAL a thing?  if it's set, shouldn't it be used?)

-Eric

> ---
>  common/quota |    6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/common/quota b/common/quota
> index fd5374f..3550cd4 100644
> --- a/common/quota
> +++ b/common/quota
> @@ -40,6 +40,12 @@ _require_quota()
>  	if [ ! -f /proc/fs/xfs/xqmstat ]; then
>  	    _notrun "Installed kernel does not support XFS quotas"
>          fi
> +	if [ "$USE_EXTERNAL" = yes -a ! -z "$TEST_RTDEV" ]; then
> +	    _notrun "Quotas not supported on realtime test device"
> +	fi
> +	if [ "$USE_EXTERNAL" = yes -a ! -z "$SCRATCH_RTDEV" ]; then
> +	    _notrun "Quotas not supported on realtime scratch device"
> +	fi
>  	;;
>      *)
>  	_notrun "disk quotas not supported by this filesystem type: $FSTYP"
>