[PATCH] xfstests: remove unconditional setting of FSTYP

David Sterba dsterba at suse.cz
Thu Mar 28 11:48:27 CDT 2013


On Thu, Mar 28, 2013 at 05:37:38PM +0100, David Sterba wrote:
> On Thu, Mar 28, 2013 at 04:39:07PM +0100, David Sterba wrote:
> > Commit 3345d2150e9e672 ("xfstests: clean up and simply check CLI option
> > parsing") hardcodes the FSTYP to xfs, testing other filesystems fails
> > with
> > 
> > common.rc: Error: $TEST_DEV (/dev/sda5) is not a MOUNTED xfs filesystem
> > 
> > Signed-off-by: David Sterba <dsterba at suse.cz>
> 
> That's not a complete fix, I haven't noticed the automatic fs detection via
> blkid, however it does not work because HOSTOS is not set:

Simply because HOSTOS is used before common/config is called. There was
one more bug left, FSTYP is not exported so it is set correctly in 'check'
but is not propagated to the subshells with tests.

david



More information about the xfs mailing list