[PATCH] xfstests: determine path of logger
Dave Chinner
david at fromorbit.com
Mon Mar 11 20:21:52 CDT 2013
On Tue, Mar 12, 2013 at 12:36:52AM +0100, David Sterba wrote:
> The path of the syslog writer utility 'logger' is hardcoded and not
> always correct, use set_prog_path.
>
> Signed-off-by: David Sterba <dsterba at suse.cz>
> ---
> check | 2 +-
> common.config | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/check b/check
> index c20179c..9a5b256 100755
> --- a/check
> +++ b/check
> @@ -243,7 +243,7 @@ do
> start=`_wallclock`
> $timestamp && echo -n " ["`date "+%T"`"]"
> [ ! -x $seq ] && chmod u+x $seq # ensure we can run it
> - [ -x /usr/bin/logger ] && /usr/bin/logger "run xfstest $seq"
> + $LOGGER_PROG "run xfstest $seq"
> ./$seq >$tmp.rawout 2>&1
> sts=$?
> $timestamp && _timestamp
> diff --git a/common.config b/common.config
> index a0b017d..ed0f44c 100644
> --- a/common.config
> +++ b/common.config
> @@ -177,6 +177,7 @@ export DUMPE2FS_PROG="`set_prog_path dumpe2fs`"
> export FIO_PROG="`set_prog_path fio`"
> export FILEFRAG_PROG="`set_prog_path filefrag`"
> export E4DEFRAG_PROG="`set_prog_path e4defrag`"
> +export LOGGER_PROG="`set_prog_path logger`"
>
> # Generate a comparable xfsprogs version number in the form of
> # major * 10000 + minor * 100 + release
Looks good.
Reviewed-by: Dave Chinner <dchinner at redhat.com>
--
Dave Chinner
david at fromorbit.com
More information about the xfs
mailing list