[PATCH V2] xfs_repair: skip freelist scan of corrupt agf in no-modify mode

Dave Chinner david at fromorbit.com
Sat Mar 9 03:00:41 CST 2013


On Fri, Mar 08, 2013 at 02:31:23PM -0600, Rich Johnston wrote:
> This version looks good. ;)
> 
> Reviewed-by: Rich Johnston <rjohnston at sgi.com>
> 
> This has been committed.

Except that all review comments have not been addressed. i.e there
are two places that have the same bug and they haven't been fixed.

It's great that you want to commit quickly, but commits should not
happen while there are unaddressed issues still outstanding....

Cheers,

Dave.
-- 
Dave Chinner
david at fromorbit.com



More information about the xfs mailing list