[PATCH V2] xfs_repair: skip freelist scan of corrupt agf in no-modify mode

Rich Johnston rjohnston at sgi.com
Fri Mar 8 14:31:23 CST 2013


This version looks good. ;)

Reviewed-by: Rich Johnston <rjohnston at sgi.com>

This has been committed.

commit 7e8e3cce00f38ee1533df0e7bda6bcb584b03e96
Author: Eric Sandeen <sandeen at sandeen.net>
Date:   Sat Mar 2 21:23:12 2013 +0000

     xfsprogs: xfs_repair skip freelist scan of corrupt agf in no-modify 
mode

     In xfs_repair's no-modify mode (-n), verify_set_agf doesn't fix up
     bad freelist blocks that it finds.  When we get to scan_freelist,
     this can wreak havoc if, for example, first > last and the loop
     never exits; we index agfl->agfl_bno[i] off into the weeds.

     To fix this, re-check the values in no-modify mode, and if
     they're off, warn about it and skip the scan.





More information about the xfs mailing list