[PATCH] xfstests: Fix hang when mkfs.btrfs isn't present
Eric Sandeen
sandeen at sandeen.net
Tue Mar 5 16:41:54 CST 2013
My earlier patch (xfstests: handle new mkfs.btrfs -f option cleanly)
had a flaw in that if set_prog_path mkfs.btrfs returns nothing,
the grep will hang.
Test for that case to avoid it, and just return the empty string
in that case.
Reported-by: Rich Johnston <rjohnston at sgi.com>
Signed-off-by: Eric Sandeen <sandeen at redhat.com>
---
diff --git a/common.config b/common.config
index c10163a..a0b017d 100644
--- a/common.config
+++ b/common.config
@@ -108,7 +108,7 @@ set_prog_path()
set_btrfs_mkfs_prog_path_with_opts()
{
p=`set_prog_path mkfs.btrfs`
- if grep -q 'force overwrite' $p; then
+ if [ "$p" != "" ] && grep -q 'force overwrite' $p; then
echo "$p -f"
else
echo $p
More information about the xfs
mailing list