[PATCH] xfstests: check if the scratch dev pool is mounted in _require_scratch
Josef Bacik
jbacik at fusionio.com
Wed Jun 26 14:34:46 CDT 2013
On Wed, Jun 26, 2013 at 12:18:04PM -0700, Zach Brown wrote:
> > $SCRATCH_DEV, so anybody who wants to just use the scratch mnt with the scratch
> > dev will fail to work because we never unmount the scratch mount.
>
> Yeah, this is annoying.
>
> > Fix this by
> > checking to see if the scratch dev pool is mounted at scratch mnt and unmount it
> > so we can run our test. This fixes the issue I was seeing by running
>
> But this fix seems bonkers. Can we have _scratch_unmount unmount the
> mountpoint instead of the device? That's what Eric suggested when I
> whined about this a while ago.
>
Well actually we probably need both, since we need callers of _scratch_umount to
actually work. But my patch is slightly wrong, I need to be making sure the
device is actually mounted at scratch mnt before I unmount it, otherwise error
out. Thanks,
Josef
More information about the xfs
mailing list