[PATCH v3 1/2] xfs: Remove XFS_MOUNT_RETERR

Ben Myers bpm at sgi.com
Wed Jun 19 14:55:06 CDT 2013


On Thu, May 02, 2013 at 07:27:47PM +0800, Jeff Liu wrote:
> From: Jie Liu <jeff.liu at oracle.com>
> 
> XFS_MOUNT_RETERR is going to be set at xfs_parseargs() if
> mp->m_dalign is enabled, so any time we enter "if (mp->m_dalign)"
> branch in xfs_update_alignment(), XFS_MOUNT_RETERR is set and so
> we always be emitting a warning and returning an error.
> 
> Hence, we can remove it and get rid of a couple of redundant
> check up against it at xfs_upate_alignment().
> 
> Thanks Dave Chinner for the suggestions of simplify the code
> in xfs_parseargs().
> 
> Signed-off-by: Jie Liu <jeff.liu at oracle.com>
> Cc: Dave Chinner <dchinner at redhat.com>
> Cc: Mark Tinguely <tinguely at sgi.com>

Applied.



More information about the xfs mailing list