[PATCH] xfs: fix sgid inheritance for subdirectories inheriting default acls

Dave Chinner david at fromorbit.com
Tue Jun 18 00:53:51 CDT 2013


On Mon, Jun 17, 2013 at 09:55:29PM -0700, Christoph Hellwig wrote:
> On Tue, Jun 18, 2013 at 02:49:31PM +1000, Dave Chinner wrote:
> > 	xfs_set_mode()
> > 	{
> > 		setup iattr
> > 		return xfs_setattr_nonsize_nomodecheck()
> > 	}
> 
> I'd rather opencode updating the mode here, it's really just a tiny bit
> of boilerplate code.

Needs a transaction, though. Right now, there's no transaction code
at all in xfs_acl.c and I'd kind of like to keep it that way as it's
just a translation layer....

Cheers,

Dave.
-- 
Dave Chinner
david at fromorbit.com



More information about the xfs mailing list