[PATCH] xfstests: print missing utility name

Lukáš Czerner lczerner at redhat.com
Wed Jun 12 09:02:19 CDT 2013


Currently when the utility such as fio or dmsetup is missing user does
not get the information about the utility name which is actually
missing. Fix it by providing second argument to the _require_command().

Signed-off-by: Lukas Czerner <lczerner at redhat.com>
---
 common/rc | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/common/rc b/common/rc
index fe6bbfc..984cef1 100644
--- a/common/rc
+++ b/common/rc
@@ -1054,6 +1054,7 @@ _require_realtime()
 _require_command()
 {
     [ -n "$1" ] && _cmd="$1" || _cmd="$2"
+    [ -z $_cmd ] && _cmd="<fill utility name>"
     [ -n "$1" -a -x "$1" ] || _notrun "$_cmd utility required, skipped this test"
 }
 
@@ -1061,7 +1062,7 @@ _require_command()
 #
 _require_dm_flakey()
 {
-    _require_command $DMSETUP_PROG
+    _require_command $DMSETUP_PROG dmsetup
 
     modprobe dm-flakey >/dev/null 2>&1
     $DMSETUP_PROG targets | grep flakey >/dev/null 2>&1
@@ -2036,7 +2037,7 @@ _require_fio()
 {
 	job=$1
 
-	_require_command $FIO_PROG
+	_require_command $FIO_PROG fio
 	if [ -z "$1" ]; then
 		return 1;
 	fi
-- 
1.8.2.1



More information about the xfs mailing list