[PATCH 2/4] xfs: inode unlinked list needs to recalculate the inode CRC

Mark Tinguely tinguely at sgi.com
Wed Jun 5 09:43:32 CDT 2013


On 06/04/13 21:09, Dave Chinner wrote:
> From: Dave Chinner<dchinner at redhat.com>
>
> The inode unlinked list manipulations operate directly on the inode
> buffer, and so bypass the inode CRC calculation mechanisms. Hence an
> inode on the unlinked list has an invalid CRC. Fix this by
> recalculating the CRC whenever we modify an unlinked list pointer in
> an inode, ncluding during log recovery. This is trivial to do and
> results in  unlinked list operations always leaving a consistent
> inode in the buffer.
>
> Signed-off-by: Dave Chinner<dchinner at redhat.com>
> ---

Looks good.

Reviewed-by: Mark Tinguely <tinguely at sgi.com>



More information about the xfs mailing list