[PATCH v7 6/7] xfs: add capable check to free eofblocks ioctl

Gao feng gaofeng at cn.fujitsu.com
Wed Jul 31 02:14:12 CDT 2013


On 07/30/2013 11:07 AM, Dwight Engen wrote:
> Check for CAP_SYS_ADMIN since the caller can truncate preallocated
> blocks from files they do not own nor have write access to. A more
> fine grained access check was considered: require the caller to
> specify their own uid/gid and to use inode_permission to check for
> write, but this would not catch the case of an inode not reachable
> via path traversal from the callers mount namespace.
> 
> Add check for read-only filesystem to free eofblocks ioctl.
> 
> Signed-off-by: Dwight Engen <dwight.engen at oracle.com>
> ---

Reviewed-by: Gao feng <gaofeng at cn.fujitsu.com>



More information about the xfs mailing list