[PATCH 23/48] xfsprogs: introduce CRC support into mkfs.xfs

Ben Myers bpm at sgi.com
Tue Jul 30 16:08:37 CDT 2013


On Fri, Jun 07, 2013 at 10:25:46AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner at redhat.com>
> 
> Signed-off-by: Dave Chinner <dchinner at redhat.com>
> ---
>  libxfs/xfs_mount.c   |   10 +++--
>  libxfs/xfs_symlink.c |    4 +-
>  mkfs/maxtrres.c      |    4 +-
>  mkfs/xfs_mkfs.c      |  114 ++++++++++++++++++++++++++++++++++++++++----------
>  mkfs/xfs_mkfs.h      |   12 +++---
>  5 files changed, 111 insertions(+), 33 deletions(-)
> 
> diff --git a/libxfs/xfs_mount.c b/libxfs/xfs_mount.c
> index f66f63d..e7e7445 100644
> --- a/libxfs/xfs_mount.c
> +++ b/libxfs/xfs_mount.c
> @@ -369,7 +369,8 @@ xfs_sb_to_disk(
>  
>  static int
>  xfs_sb_verify(
> -	struct xfs_buf	*bp)
> +	struct xfs_buf	*bp,
> +	bool		verbose)

xfs_sb_verify in userspace and xfs_sb_verify in the kernel both have a boolean
arg but they mean different things.  Could get confusing.

Anyway, looks good.

Reviewed-by: Ben Myers <bpm at sgi.com>



More information about the xfs mailing list