[PATCH] xfs: Fix the logic check for all quotas being turned off

Ben Myers bpm at sgi.com
Thu Jul 11 16:41:44 CDT 2013


On Wed, Jul 10, 2013 at 06:00:36PM -0500, Chandra Seetharaman wrote:
> 
> During the review of seperate pquota inode patches, David noticed
> that the test to detect all quotas being turned off was
> incorrect, and hence the block was not freeing all the quota
> information.
> 
> The check made sense in Irix, but in Linux, quota is turned off
> one at a time, which makes the test invalid for Linux.
> 
> This problem existed since XFS was ported to Linux.
> 
> David suggested to fix the problem by detecting when all quotas are
> turned off by checking m_qflags.
> 
> Signed-off-by: Chandra Seetharaman <sekharan at us.ibm.com>

This looks ok to me. 

Reviewed-by: Ben Myers <bpm at sgi.com>



More information about the xfs mailing list