Fwd: Re: [PATCH 13/15] xfs: remove local fork format handling from xfs_bmapi_write()

[Mark Tinguely]

Sorry, I did not add the mailing list.

--Mark.

-------- Original Message --------
Subject: Re: [PATCH 13/15] xfs: remove local fork format handling from 
xfs_bmapi_write()
Date: Thu, 27 Jun 2013 21:09:53 -0500
From: Mark Tinguely <tinguely at sgi.com>
To: Dave Chinner <david at fromorbit.com>

On 06/27/13 01:04, Dave Chinner wrote:
> From: Dave Chinner<dchinner at redhat.com>
>
> The conversion from local format to extent format requires
> interpretation of the data in the fork being converted, so it cannot
> be done in a generic way. It is up to the caller to convert the fork
> format to extent format before calling into xfs_bmapi_write() so
> format conversion can be done correctly.
>
> The code in xfs_bmapi_write() to convert the format is used
> implicitly by the attribute and directory code, but they
> specifically zero the fork size so that the conversion does not do
> any allocation or manipulation. Move this conversion into the
> shortform to leaf functions for the dir/attr code so the conversions
> are explicitly controlled by all callers.
>
> Now we can remove the conversion code in xfs_bmapi_write.
>
> Signed-off-by: Dave Chinner<dchinner at redhat.com>
> ---

Looks good.

Reviewed-by: Mark Tinguely <tinguely at sgi.com>