[PATCH 3/5] xfs: always hold the iolock when calling xfs_change_file_space

Mark Tinguely tinguely at sgi.com
Fri Jan 25 16:57:11 CST 2013


On 12/08/12 06:08, Christoph Hellwig wrote:
> Currently fallocate always holds the iolock when calling into
> xfs_change_file_space, while the ioctl path lets some of the lower level
> functions take it, but leave it out in others.
>
> This patch makes sure the ioctl path also always holds the iolock and
> thus introduces consistent locking for the preallocation operations while
> simplifying the code and allowing to kill the now unused XFS_ATTR_NOLOCK
> flag.
>
> Signed-off-by: Christoph Hellwig<hch at lst.de>

A first for me, seeing you ADD a lock. :)

Looks good.

Reviewed-by: Mark Tinguely <tinguely at sgi.com>



More information about the xfs mailing list