[PATCH] xfstests: test for file clone functionality of btrfs ("reflinks")

[Koen De Wit]

Dave and David,

Thanks for your extensive reviews. I have rewritten the testscripts 
according to your comments. The original script is split into 6 smaller 
scripts, as suggested by Dave. The 7th patch is a new testscript for 
send/receive.

Koen.


On 01/10/2013 02:15 PM, David Sterba wrote:
> David did a review and I agree with all of his comments. I have a few
> suggestions to extend test scope:
>
> * check if reflink expectedly fails when it's done on the same
>    filesystem but mounted to 2 different directories (for example bind
>    mount the TEST partition to SCRATCH dir and do the reflinks)
>    
I've added this to test 301.
> * most of the files are very small and will get inlined, this
>    covers only a small range of problems that could arise from reflinks.
>    I'd like to see this included in the initial test version so the test
>    covers majority of the cases and we can add specific corner cases
>    later
>    
All tests create bigger files of variable size now.
> * larger files allow to test reflinks on files that comprise of
>    interesting mix of holes and data (eg. what happens if I reflink half
>    of hole and data extent at once?), reflink beginning or end of a file
>    to another file
>    
I'm planning to write a testscript for file hole punching with btrfs in 
future, I will include a test with reflinks then.