[xfs:for-next 7/8] fs/xfs/xfs_log.c:1740:39: error: 'B_TRUE' undeclared

[Mark Tinguely]

On 01/18/13 14:17, Ben Myers wrote:
> On Thu, Jan 17, 2013 at 10:52:10PM -0200, Thiago Farina wrote:
>> On Thu, Jan 17, 2013 at 10:16 PM, kbuild test robot
>> <fengguang.wu at intel.com>  wrote:
>>> tree:   git://oss.sgi.com/xfs/xfs for-next
>>> head:   9e96fe6df44425b69ed89f6ac20352cec1f127d7
>>> commit: 667a9291c5b38318a47a2df730bc064e5d37d2a8 [7/8] xfs: Remove boolean_t typedef completely.
>>> config: make ARCH=x86_64 allmodconfig
>>>
>>> All error/warnings:
>>>
>>>     fs/xfs/xfs_log.c: In function 'xlog_sync':
>>>>> fs/xfs/xfs_log.c:1740:39: error: 'B_TRUE' undeclared (first use in this function)
>>>     fs/xfs/xfs_log.c:1740:39: note: each undeclared identifier is reported only once for each function it appears in
>>>
>>> vim +/B_TRUE +1740 fs/xfs/xfs_log.c
>>>
>>>    1734                          bp->b_flags |= XBF_FLUSH;
>>>    1735          }
>>>    1736
>>>    1737          ASSERT(XFS_BUF_ADDR(bp)<= log->l_logBBsize-1);
>>>    1738          ASSERT(XFS_BUF_ADDR(bp) + BTOBB(count)<= log->l_logBBsize);
>>>    1739
>>>> 1740          xlog_verify_iclog(log, iclog, count, B_TRUE);
>>>    1741
>> s/B_TRUE/true
>> ?
>
> You are correct.  I neglected to do a debug build.  Fail.  :/
>
> From: Ben Myers<bpm at sgi.com>
> xfs: fix debug build
>
> Commit 667a9291c5b3 "xfs: Remove boolean_t typedef completely." didn't.
>
> Remove a stray B_TRUE that breaks CONFIG_XFS_DEBUG=y.
>
> Signed-off-by: Ben Myers<bpm at sgi.com>
> Reported-by: Wu Fengguang<fengguang.wu at intel.com>
>
> Index: xfs/fs/xfs/xfs_log.c
> ===================================================================
> --- xfs.orig/fs/xfs/xfs_log.c
> +++ xfs/fs/xfs/xfs_log.c
> @@ -1737,7 +1737,7 @@ xlog_sync(
>   	ASSERT(XFS_BUF_ADDR(bp)<= log->l_logBBsize-1);
>   	ASSERT(XFS_BUF_ADDR(bp) + BTOBB(count)<= log->l_logBBsize);
>
> -	xlog_verify_iclog(log, iclog, count, B_TRUE);
> +	xlog_verify_iclog(log, iclog, count, true);
>
>   	/* account for log which doesn't start at block #0 */
>   	XFS_BUF_SET_ADDR(bp, XFS_BUF_ADDR(bp) + log->l_logBBstart);
>


Looks good. Though it looks like xlog_verify_iclog() has only been
called with syncing=true for a long time. Probably a routine that
could use some cleaning.

Reviewed-by: Mark Tinguely <tinguely at sgi.com>