[PATCH] xfs: pull up stack_switch check into xfs_bmapi_write

Dave Chinner david at fromorbit.com
Thu Jan 17 17:31:09 CST 2013


On Thu, Jan 17, 2013 at 01:11:29PM -0500, Brian Foster wrote:
> The stack_switch check currently occurs in __xfs_bmapi_allocate,
> which means the stack switch only occurs when xfs_bmapi_allocate()
> is called in a loop. Pull the check up before the loop in
> xfs_bmapi_write() such that the first iteration of the loop has
> consistent behavior.
> 
> Signed-off-by: Brian Foster <bfoster at redhat.com>

Yeah, that's a bug. As i mentioned on IRC, the backup copy of the
patch I have has these two hunks in it. Why they got dropped from
the primary copy is have no idea - perhaps it was an issue with
popping and pushing patches on and off my stack, and the hunks got
silently dropped...

I note that the port to the RHEL6 codebase has this correct - and
looking a the patch I ported it is the same as the backup copy in my
mainline guilt patch directory. So the intention was there that the
stack switch should have been moved, but it wasn't and the logic
problem wasn't picked up on review, so here we are...

Anyway, looks good.

Reviewed-by: Dave Chinner <dchinner at redhat.com>

-- 
Dave Chinner
david at fromorbit.com



More information about the xfs mailing list