[PATCH V2] xfsprogs: document all commands in xfs_io

Mark Tinguely tinguely at sgi.com
Wed Jan 16 17:27:46 CST 2013


On 01/16/13 17:18, Eric Sandeen wrote:
> On 1/14/13 8:33 AM, Mark Tinguely wrote:
>> On 12/08/12 14:55, Eric Sandeen wrote:
>>> Add missing command documentation to xfs_io(8) manpage.
>>> fiemap, fpunch, chproj, lsproj, and setfl are all missing.
>>>
>>> setfl seems to not work today in any case, and nothing
>>> in xfstests uses it; I will send another patch to simply
>>> remove it from xfs_io, as I don't think it's terribly useful,
>>> and hasn't worked forever anyway.
>>>
>>> Also fix references to the fallocate manpage, which is (now?)
>>> in section 2, not section 3 of the man pages.  (Since it's
>>> a syscall, not a library function).
>>>
>>> Signed-off-by: Eric Sandeen<sandeen at sandeen.net>
>>> ---
>>>
>>
>> Looks good. Committed to xfsprogs as 83c324
>
> Thanks.  Any plans to merge the other 3?
>
> [PATCH] xfsprogs: remove setfl from xfs_io

  ^^^ have this ready to commit, just holding my breath in case
      someone wanted to have it fixed rather than removed.
      <play sound of crickets chirping>

> [PATCH] xfsprogs: document fpunch command in xfs_io

  ^^^ Turns out to be superseded by the above patch.

> [PATCH] xfstests: ensure all xfs_io commands are documented in the manpage

  ^^^ This one is ready, waiting for the setfl feature removal.

If I don't hear anything overnight, I will remove the setfl feature and
commit the new test.

--Mark.



More information about the xfs mailing list